Add method to read metadata back from the xml#102
Merged
ehrenfeu merged 7 commits intoimcf:develfrom Jan 19, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #102 +/- ##
====================================
- Coverage 24% 24% -0%
====================================
Files 25 25
Lines 1742 1788 +46
====================================
+ Hits 425 429 +4
- Misses 1317 1359 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ehrenfeu
added
enhancement
ehrenfeu
approved these changes
Jan 14, 2026
ehrenfeu
requested changes
Jan 14, 2026
src/imcflibs/imagej/bdv.py
Outdated
| if last_nodes.getLength() > 0: | ||
| nbr_tp = int(last_nodes.item(0).getTextContent()) + 1 | ||
| except Exception as e: | ||
| log.error("Error extracting metadata from XML: {0}".format(str(e))) |
Member
There was a problem hiding this comment.
Is this valid Python 2.7 syntax...? 😳
Member
|
Add to changelog (cf. #126) |
* Improve syntax for python 2.7. * Ensure the Java reader is closed to free resources * Use log.exception for better error logging * Clean up unnecessary blank lines
ehrenfeu
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96